Feature/1012 tabs and storages #1028
Conversation
…e' into feature/1012-tabs
…t-page-auto-create-storage
core/systems/project/_assembly.ex
Outdated
| end | ||
| else | ||
| {:error, "Project creation failed"} | ||
| end |
There was a problem hiding this comment.
Looks good 👍
Next thing is to make the "storage creation" part of the transaction to prevent any project to exist without storage:
Multi.new()
|> Multi.insert(:project, project)
|> Multi.insert(:storage, fn %{project: inserted_project} -> prepare_storage(inserted_project) end))
|> EctoHelper.run(:auth, &update_auth/2)
|> Repo.transaction()
The idea is that you can capture the just inserted project from the transaction and use this one. Now the storage will not be created if the project failed to be created.
There was a problem hiding this comment.
Please check out the new version of this, and confirm this is what you were looking for.
|
@AdrienneMendrik de vertalingskeys staan hierin |
|
ik krijg het nog niet voor elkaar om te testen of de flash messages goed werken @mellelieuwes |
| {:ok, | ||
| put_flash( | ||
| socket, | ||
| :info, | ||
| dgettext("eyra-project", "node.data.empty.create-storage-success") | ||
| )} | ||
|
|
There was a problem hiding this comment.
@mellelieuwes deze :ok lijkt niet correct te zijn, maar als ik er :reply/:noreply van maak werkt het niet meer. Weet jij wat ik hier zou moeten teruggeven
| endpoint | ||
| ) | ||
| |> Ecto.Changeset.put_assoc(:node, project.root) | ||
| end) | ||
| |> EctoHelper.run(:auth, &update_auth/2) |
There was a problem hiding this comment.
Is this line necessary here?
| {:ok, Repo.preload(project, :root)} | ||
| end) | ||
| |> Multi.insert(:storage_endpoint, fn %{project: project} -> | ||
| key = "project_node=#{project.root.id}" |
There was a problem hiding this comment.
Consider this naming rule to be centralized somewhere, possibly in the Project.Private module.
No description provided.