Sync to 2.31.0 upstream chart repo & add missing volume snapshot resource and CRDs (SC-3707) #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some much needed features in the latest Velero chart 2.31.0 (we are currently running
2.17.2
). The main one being the added ability to allow Velero to update existing resources in place, instead of saying they already exist and erroring. This is essential for our Zeebe PV restore DR strategy. The velero backed up PV and PVCs cannot be restored with older version of Velero unless the PVs and PVCs are deleted first.In addition to the new
existingResourcePolicy: update
feature, I'm also adding the core kubernetes CRDs that are required for the VeleroVolumeSnapshotClass
CRD (needed for allowing Velero to backup CSI managed PV (EBS) volumes).Broken down by commits:
I added commits 2 and 3 to this forked top level helm chart (instead of putting them in our sub chart in
kubernetes-clusters
) because the CRDs andVolumeSnapshotClass
resource are 100% required for our kubernetes cluster setups (they all run Velero).Tested in
staging1
(live now)All existing backup schedules, backups, PVs etc.. were all retained and the new Velero appVersion is correct
1.9.0
and the needed CRDs and volume snapshot class stuff was also all created. Tested backup and restore w/ Jon G.. works fine.I'll have a PR up for the staging1 (and also production1) sub chart changes to use this new chart version shortly. I also already built and pushed this new parent (forked) chart version to AF (hence, I was able to test w/ our sub chart in
staging1
).