Skip to content

Commit

Permalink
fixed building issues on new rn architecture
Browse files Browse the repository at this point in the history
  • Loading branch information
f-23 committed Sep 9, 2024
1 parent 3a008cd commit 553269d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ dependencies {

if (isNewArchitectureEnabled()) {
react {
jsRootDir = file("../src/")
jsRootDir = file("../lib/commonjs")
libraryName = "Passkey"
codegenJavaPackageName = "com.reactnativepasskey"
}
Expand Down
5 changes: 1 addition & 4 deletions android/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.reactnativepasskey">

</manifest>
<manifest xmlns:android="http://schemas.android.com/apk/res/android" />
2 changes: 1 addition & 1 deletion example/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
buildscript {
ext {
buildToolsVersion = "34.0.0"
minSdkVersion = 21
minSdkVersion = 24
compileSdkVersion = 34
targetSdkVersion = 34

Expand Down

0 comments on commit 553269d

Please sign in to comment.