Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add more interaction test on Windows and macOS #1729

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Nov 24, 2024

Do not put all interaction tests in LONG_TIMEOUT and only disable LONG_TIMEOUT on macos.
Exclude a few tests that are failing because of macOS openGL impl.

The results is more testing on Windows and macOS

@mwestphal mwestphal changed the title test Tests: Add more interaction test on windows and macos Nov 26, 2024
@mwestphal mwestphal changed the title Tests: Add more interaction test on windows and macos Tests: Add more interaction test on Windows and macOS Nov 26, 2024
Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.96%. Comparing base (d8ea37a) to head (5bf3023).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1729   +/-   ##
=======================================
  Coverage   96.95%   96.96%           
=======================================
  Files         110      110           
  Lines        8810     8825   +15     
=======================================
+ Hits         8542     8557   +15     
  Misses        268      268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal merged commit d036a4e into f3d-app:master Nov 26, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants