Added command script and relevant script file processing #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
reviewed
Nov 26, 2024
mwestphal
reviewed
Nov 26, 2024
mwestphal
reviewed
Nov 26, 2024
mwestphal
requested changes
Nov 26, 2024
mwestphal
reviewed
Nov 26, 2024
mwestphal
reviewed
Nov 26, 2024
mwestphal
reviewed
Nov 26, 2024
mwestphal
reviewed
Nov 26, 2024
mwestphal
reviewed
Nov 26, 2024
mwestphal
reviewed
Nov 27, 2024
mwestphal
reviewed
Nov 27, 2024
mwestphal
reviewed
Nov 27, 2024
mwestphal
reviewed
Nov 28, 2024
mwestphal
reviewed
Nov 28, 2024
mwestphal
reviewed
Nov 28, 2024
mwestphal
reviewed
Nov 29, 2024
mwestphal
reviewed
Nov 29, 2024
mwestphal
reviewed
Dec 1, 2024
mwestphal
requested changes
Dec 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1734 +/- ##
==========================================
- Coverage 96.97% 95.71% -1.27%
==========================================
Files 110 118 +8
Lines 8872 9349 +477
==========================================
+ Hits 8604 8948 +344
- Misses 268 401 +133 ☔ View full report in Codecov by Sentry. |
mwestphal
reviewed
Dec 2, 2024
mwestphal
requested changes
Dec 2, 2024
Meakk
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing Issue #1694, added --command-script CLI option.
Includes adding a CLI option in F3DOptionsTools.cxx called
--command-scriptAdded the CLI option in F3DOptionsTools.h
In F3DStarter.cxx, implemented relevant code to process the provided file and utilized
interactor::triggerCommandto trigger the commands.Added relevant comments/documentation along with a commandScript test.