Skip to content

Commit

Permalink
Bump version to 1.3.9
Browse files Browse the repository at this point in the history
  • Loading branch information
alfonsogarciacaro committed Mar 1, 2018
1 parent 28e2daa commit 1f787ff
Show file tree
Hide file tree
Showing 9 changed files with 297 additions and 599 deletions.
2 changes: 1 addition & 1 deletion build.fsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ let project = "Fable"
let gitOwner = "fable-compiler"
let gitHome = "https://github.com/" + gitOwner

let dotnetcliVersion = "2.1.4"
let dotnetcliVersion = "2.1.300-preview1-008174"
let mutable dotnetExePath = environVarOrDefault "DOTNET" "dotnet"

let CWD = __SOURCE_DIRECTORY__
Expand Down
870 changes: 280 additions & 590 deletions paket.lock

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions src/dotnet/Fable.Compiler/FSharp2Fable.Util.fs
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,10 @@ module Helpers =
let typ = nonAbbreviatedType typ
if typ.HasTypeDefinition then Some typ.TypeDefinition else None

// Sometimes accessing `EnclosingEntity` throws an error (e.g. compiler generated
// Sometimes accessing `DeclaringEntity` throws an error (e.g. compiler generated
// methods as in #237) so this prevents uncaught exceptions
let tryEnclosingEntity (meth: FSharpMemberOrFunctionOrValue) =
try meth.EnclosingEntity
try meth.DeclaringEntity
with _ -> None

let isModuleMember (meth: FSharpMemberOrFunctionOrValue) =
Expand Down Expand Up @@ -249,7 +249,7 @@ module Helpers =

let getMemberKind (meth: FSharpMemberOrFunctionOrValue) =
let ent = tryEnclosingEntity meth
// `.EnclosingEntity` only fails for compiler generated module members
// `.DeclaringEntity` only fails for compiler generated module members
if ent.IsNone || (ent.Value.IsFSharpModule) then
if meth.CurriedParameterGroups.Count = 0
&& meth.GenericParameters.Count = 0
Expand Down Expand Up @@ -1187,7 +1187,7 @@ module Util =
// the type and meth generic arguments, so this first folding is not necessary
// let genArgs =
// if meth.IsModuleValueOrMember then
// ([], meth.EnclosingEntity.GenericParameters, typArgs)
// ([], meth.DeclaringEntity.GenericParameters, typArgs)
// |||> Seq.fold2 (fun acc genPar (ResolveGeneric ctx t) -> acc@[genPar.Name, t])
// else []
([], meth.GenericParameters, typArgs@methTypArgs)
Expand Down
2 changes: 1 addition & 1 deletion src/dotnet/Fable.Compiler/Fable.Compiler.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<PackageIconUrl>https://raw.githubusercontent.com/fable-compiler/Fable/master/docs/img/fable_logo.png</PackageIconUrl>
<PackageTags>fsharp;fable;javascript;f#;js</PackageTags>
<Authors>Alfonso García-Caro Núñez</Authors>
<Version>1.3.8</Version>
<Version>1.3.9</Version>
<TargetFramework>netstandard1.6</TargetFramework>
</PropertyGroup>
<ItemGroup>
Expand Down
4 changes: 4 additions & 0 deletions src/dotnet/Fable.Compiler/RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
### 1.3.9

* Update FCS

### 1.3.8

* See dotnet-fable 1.3.8 release notes
Expand Down
2 changes: 1 addition & 1 deletion src/dotnet/dotnet-fable/Printers.fs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ let attribsOfSymbol (s:FSharpSymbol) =
if v.IsValueType then yield "valuetype"

| :? FSharpMemberOrFunctionOrValue as v ->
yield "owner: " + match v.EnclosingEntity with | Some e -> e.CompiledName | _ -> "<unknown>"
yield "owner: " + match v.DeclaringEntity with | Some e -> e.CompiledName | _ -> "<unknown>"
if v.IsActivePattern then yield "active_pattern"
if v.IsDispatchSlot then yield "dispatch_slot"
if v.IsModuleValueOrMember && not v.IsMember then yield "val"
Expand Down
4 changes: 4 additions & 0 deletions src/dotnet/dotnet-fable/RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
### 1.3.9

* Update FCS

### 1.3.8

* Remove empty intermediate functions (@vbfox)
Expand Down
2 changes: 1 addition & 1 deletion src/dotnet/dotnet-fable/ToolsUtil.fs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ namespace Fable.CLI

module Constants =

let [<Literal>] VERSION = "1.3.8"
let [<Literal>] VERSION = "1.3.9"
let [<Literal>] DEFAULT_PORT = 61225

/// These values must be only set by the Main method
Expand Down
2 changes: 1 addition & 1 deletion src/dotnet/dotnet-fable/dotnet-fable.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<PackageIconUrl>https://raw.githubusercontent.com/fable-compiler/Fable/master/docs/img/fable_logo.png</PackageIconUrl>
<PackageTags>fsharp;fable;javascript;f#;js</PackageTags>
<Authors>Alfonso García-Caro Núñez</Authors>
<Version>1.3.8</Version>
<Version>1.3.9</Version>
<OutputType>Exe</OutputType>
<PackageType>DotnetCliTool</PackageType>
<TargetFramework>netcoreapp2.0</TargetFramework>
Expand Down

0 comments on commit 1f787ff

Please sign in to comment.