Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ergom_zoo.F90 #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harshalchauhan18
Copy link

No description provided.

@harshalchauhan18
Copy link
Author

Added DIC release by the zooplankton excretion.

@jornbr
Copy link
Member

jornbr commented Dec 15, 2021

Thanks for updating the uhh code. My main comment on this pull requests and the others, however, is that you're reverted preprocessor macros like _ADD_SOURCE_ to their old, deprecated version (in this case, _SET_ODE_). That's not a good idea, as those old macros will be removed in the next FABM version. Similarly, you're still working with namelists in your initialize routines, but the current FABM version does not read those anymore, so there is certainly no need to extend them. Instead, it would be better to remove them altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants