-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New converged booking attempt #18
base: WIP-operator-complete-api-initial-version
Are you sure you want to change the base?
New converged booking attempt #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adelcasse, thanks for this proposal.
The deeplink case with an additional pre-initialization call looks a bit complicated for me and not necessary as the booking_events
looks enough to synchronize all the bookings, but maybe I miss some constraints.
I also added 2 minor comments
CarpoolBookingEvent: | ||
required: | ||
- id | ||
- passengerAccessKey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not described. Did you mean passengerToken
?
webUrl: | ||
type: string | ||
description: URL of the booking on the webservice provider platform. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be missing:
driver:
$ref: '#/components/schemas/User'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adelcasse,
Thank you for this proposal.
Sorry but I don't understand, all the Interact
don't seem to have something to do with the need of sending booking information back to the MaaS platform.
We have two separate PR to describe the "Booking" / Interact
(#6) and the "Feed" / Webhooks
(#5) use-cases. Why not keep them separated so we don't mix everything's up?
Needs expressed by the people from Mobility by Colas seem quite specific and maybe they can fit in the Interact
. If so, it should be added to PR#6. Or in a completely separated PR so we can measure what supporting this specific need implies / have a dedicated conversation about it.
I will add elements to PR#5 to support expressed needs & feedbacks (including the ones that appear here, from @tcroiset & me).
- status | ||
- price | ||
|
||
CarpoolBookingEvent: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From its structure, this is not an "event" but a "booking". Calling it an event will bring confusion, particularly about the id
that must be the unique identifier of the booking.
type: string | ||
description: URL of the booking on the webservice provider platform. | ||
|
||
bookingId: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a subsequent bookingId
brings even more confusion (vs previous id
).
@tcroiset @ccyrille this was a proof of concept of my idea I wrote quickly after our last meeting. Of course we can change order of paragraphs, etc... Mayve event change the structuration of all of while looking at how it could integrate with the description of the standard proposed in #12 ? @tcroiset The difference between the webhook and the API + deeplink is the nature of the link to the MaaS
|
Following our discussions today, I made a new attempt on converged booking to merge PR #6 and PR #5.
During discussions in the end of the meeting with @ccyrille and previous discussions with Mobility by Colas, I figured out there might by 3 flows instead of 2 (1 with booking by API, and 2 flows to retrieve booking information with booking by deeplink) :
The booking by API flow is quite clear as it is always initiated by the MaaS
For the booking by deeplink, there were 2 considerations :
For these 2 flows, I described distinct processes :