Move sequencing to concurrent coroutine to unblock driver control loop #21
Conversation
| let engine_driver = driver.engine_driver.clone(); | ||
| let state = driver.state.clone(); | ||
| self.start_sequencing_driver(engine_driver, state) | ||
| }; |
There was a problem hiding this comment.
i suggest to use tokio::spawn for sequencing
There was a problem hiding this comment.
tried doing this but need to wrestle w/ borrow checker, will defer
| /// List of unfinalized L2 blocks with their epochs, L1 inclusions, and sequence numbers | ||
| unfinalized_blocks: Vec<(BlockInfo, Epoch, u64, u64)>, | ||
| /// Current finalized L1 block number | ||
| finalized_l1_block_number: u64, | ||
| /// List of unsafe blocks that have not been applied yet | ||
| future_unsafe_blocks: Vec<ExecutionPayload>, | ||
| /// State struct to keep track of global state | ||
| state: Arc<RwLock<State>>, | ||
| pub state: Arc<RwLock<State>>, |
There was a problem hiding this comment.
can we also use tokio rwlock here? ref a16z#164
There was a problem hiding this comment.
it's okay as long as you don't hold the lock across await points (clippy checks this). async RwLocks have additional overhead unfortunately. I'll look into it separately
|
|
||
| if let Some(payload) = next_unsafe_payload { | ||
| _ = self.engine_driver.handle_unsafe_payload(payload).await; |
There was a problem hiding this comment.
can we move this to engine_driver.rs? like a top-level function called handle_unsafe_payload
There was a problem hiding this comment.
it's a bit awkward to because of where the first read lock is acquired/released, i can try to refactor later by having a function that takes an optional guard
ujvl
changed the title
SequencingDriver)tokio::RwLockonengine_driverengine_driverfunctionality and abstract out functions by whether or not they require&mut self. this is necessary to reduce the critical section for write-locking (e.g. shouldn't write-lock while sleeping for 2s inbuild_payload)todo in future PR: avoid extraneous fork-choice updates (e.g. we can do a single update per control loop iteration)