Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add profile view page with edit modal functionality #82

Closed
wants to merge 1 commit into from

Conversation

vlbee
Copy link
Collaborator

@vlbee vlbee commented May 11, 2018

relates #14 #44 #41

  • Redirect logins/sign up to view profile view.
  • Upon clicking edit details, frontend event listener displays Edit My Details modal with autopopulated info
  • Currently the modal closes on hitting escap but not out of the modal - do we need this or can we add a "Save" / "Close without Saving" button into the modal instead? I think this is easier and better functionality - especially if we want to adapt to mobile were the modal will take up the entire viewport. I don't think we need close on clicking window outside of the modal

@vlbee vlbee added this to the Build Sprint 1 milestone May 11, 2018
@vlbee vlbee requested review from LawEKS, helenzhou6 and tdoran May 11, 2018 17:23
Copy link
Collaborator

@helenzhou6 helenzhou6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job guys! 🎉

I might work off this branch this weekend (including editing the .hbs files and looking at the javascript to interact with the profile page in the front end), and possibly a little CSS - I'll push my changes to the branch profile-view-build-hbs-additions




<nav id="navigation">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an .hbs file for the main navigation - views > partials > header.hbs so these link can be placed there.


<header>
<h1>
MY DETAILS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use CSS to transform text to uppercase, which may be more ideal than hardcoding uppercase text.

<a href="" class="" id="">MY PROFILE</a>
</nav>

<header>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps consider splitting the profile view components (header and article) into a separate .hbs file.

@helenzhou6 helenzhou6 changed the title add profile view page with edit modal functionality add profile view page with edit modal functionality - WIP May 12, 2018
@helenzhou6 helenzhou6 changed the title add profile view page with edit modal functionality - WIP add profile view page with edit modal functionality May 12, 2018
@helenzhou6
Copy link
Collaborator

Closed since part of pull request #83

@helenzhou6 helenzhou6 closed this May 14, 2018
@helenzhou6 helenzhou6 deleted the profile-view-build-hbs branch May 14, 2018 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants