-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add profile view page with edit modal functionality #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job guys! 🎉
I might work off this branch this weekend (including editing the .hbs files and looking at the javascript to interact with the profile page in the front end), and possibly a little CSS - I'll push my changes to the branch profile-view-build-hbs-additions
|
||
|
||
|
||
<nav id="navigation"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an .hbs
file for the main navigation - views > partials > header.hbs
so these link can be placed there.
|
||
<header> | ||
<h1> | ||
MY DETAILS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use CSS to transform text to uppercase, which may be more ideal than hardcoding uppercase text.
<a href="" class="" id="">MY PROFILE</a> | ||
</nav> | ||
|
||
<header> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps consider splitting the profile view components (header
and article
) into a separate .hbs
file.
Closed since part of pull request #83 |
relates #14 #44 #41