Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage pop #90

Merged
merged 9 commits into from
Aug 7, 2024
Merged

Homepage pop #90

merged 9 commits into from
Aug 7, 2024

Conversation

halimahexe
Copy link
Contributor

Description

Added some additional content to the homepage.

image

Related Issue

Relates #25

How Can This Be Tested?

Run the app and view the extra content!

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings, including npm run build
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Collaborator

@oskarprzybylski23 oskarprzybylski23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better! A couple comments:

There's just a minor thing I've noticed earlier. There is a blank white bar at the bottom of the page above the footer. Could this be removed?

Also, book my session button on Fahan's Card leads to a non-exsitent route. I think this should redirect to booking page.

I would also consider centering section with photo and paragraph instead of justifying to the left and giving it max width value.

Thanks

Copy link
Collaborator

@oskarprzybylski23 oskarprzybylski23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making changes!

@oskarprzybylski23 oskarprzybylski23 merged commit 0780e5f into main Aug 7, 2024
@oskarprzybylski23 oskarprzybylski23 deleted the homepage-pop branch August 7, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants