Skip to content
This repository has been archived by the owner on Sep 1, 2021. It is now read-only.

Add support noAsar through process.env #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

packlikez
Copy link

To disable ASAR support, we have to set process.Asar = true, but it doesn't pass through spawning child process, when running the tests. so the electron that was spawned by the runner doesn't know that we set no ASAR support.

To fix it, I would like to use process.env.noAsar to pass through process.noAsar when spawn child process

@facebook-github-bot
Copy link

Hi @packlikez!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 31, 2021
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants