Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the bad request url at banner #13674

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chandankumarm55
Copy link

@chandankumarm55 chandankumarm55 commented Sep 15, 2024

This PR fixes the bad resource link mentioned in issue #13649. The issue was that the app was making a request to the URL camo.githubusercontent.com, which resulted in a 404 page not found error. I downloaded the original image and added it locally to avoid any external requests, ensuring the image will load permanently. The link has been updated accordingly.

Issue #13649 is now resolved.

Screenshot 2024-09-15 225259
Screenshot 2024-09-15 225305

Copy link

@akashprasher akashprasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{' '} everywhere?

@chandankumarm55
Copy link
Author

chandankumarm55 commented Sep 22, 2024

@akashprasher oh yeah but i didnt change anything wait let me check with main branch code

@chandankumarm55
Copy link
Author

@akashprasher can u check now i have removed the {' '}

Copy link

@joaugustoo joaugustoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the {' '}, everything seems to be correct in the code. Thank you!

@chandankumarm55
Copy link
Author

Please Merge this pull request ...!!

@chandankumarm55
Copy link
Author

Can u please close this PR as soon as possible please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants