Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add badge to display install size #4534

Closed
wants to merge 1 commit into from
Closed

Add badge to display install size #4534

wants to merge 1 commit into from

Conversation

styfle
Copy link

@styfle styfle commented May 29, 2018

This adds a badge to the README.md file to display the npm install size

Related: #3880

@styfle styfle mentioned this pull request May 29, 2018
Open
@gaearon
Copy link
Contributor

gaearon commented May 29, 2018

I don't think this is really relevant because it measures CRA shell itself instead of react-scripts.
I also don't think this information is more relevant than distracting to first-time users.
(We have enough “why do I need 100 MB to create a website” memes already :-)

Thanks for PR though!

@gaearon gaearon closed this May 29, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
@styfle styfle deleted the patch-1 branch March 8, 2019 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@styfle @gaearon @facebook-github-bot