Skip to content

Commit

Permalink
Fix {fmt} breaking OSS build
Browse files Browse the repository at this point in the history
As t_whisker_generator was introduced in bbbd038,
it broke the OSS build with `error: ‘join’ is not a member of ‘fmt’`.

The newer versions of {fmt} have `format::join` in `fmt/ranges.h`.

Fixes:

```
thrift/compiler/generate/t_whisker_generator.cc:117:40: error: ‘join’ is not a member of ‘fmt’
  117 |         "{}/{}", template_prefix, fmt::join(start, partial_path.end(), "/"));
      |                                        ^~~~
```

https://github.com/facebook/fbthrift/actions/runs/12822463794/job/35755425223
  • Loading branch information
markbhasawut committed Jan 17, 2025
1 parent a43cba2 commit 88235d1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion thrift/compiler/generate/t_whisker_generator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#include <cstddef>
#include <fstream>

#include <fmt/core.h>
#include <fmt/ranges.h>

#include <boost/algorithm/string/split.hpp>

Expand Down

0 comments on commit 88235d1

Please sign in to comment.