Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix deprecated behaviour in folly/Subprocess.h
Summary: Future C++ standards and compiler upgrades will eliminate deprecated behaviour. `-Wdeprecated` identifies this behaviour and has found some in this code! Some examples. **Dynamic exceptions** ``` error: dynamic exception specifications are deprecated [-Werror,-Wdeprecated-dynamic-exception-spec] ``` `throw(...)` has been deprecated since C++11 and removed in C++17. In most cases we can just use `noexcept` in the rest, we can remove this. **Implicit copy constructors** ``` error: definition of implicit copy constructor for 'XXX' is deprecated because it has a user-declared destructor [-Werror,-Wdeprecated-copy-with-dtor] ``` If you define a destructor, you need to explicitly define a copy constructor. **Out-ofline constexpr static** ``` error: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Werror,-Wdeprecated] ``` This can be simplified: ``` class MyClass { static constexpr my_const = 3; }; static constexpr MyClass::my_const; // <- No longer needed! ``` Reviewed By: meyering Differential Revision: D54158200 fbshipit-source-id: 48d316b567810ddf8547038232eeef97b4054f61
- Loading branch information