Skip to content

Commit

Permalink
skip likeliness annotation in BitVectorReader ctor
Browse files Browse the repository at this point in the history
Summary: The smallest codegen is just to emit `test ; je ; mov` where the control may conditionally skip over just the `mov`. Likeliness annotations make the codegen larger and more complicated for little gain.

Reviewed By: Orvid

Differential Revision: D48155222

fbshipit-source-id: a03ae71f5d81883a307a25cb38983286f3155f69
  • Loading branch information
yfeldblum authored and facebook-github-bot committed Aug 8, 2023
1 parent c52d449 commit 50b3142
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions folly/experimental/BitVectorCoding.h
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,7 @@ class BitVectorReader : detail::ForwardPointers<Encoder::forwardQuantum>,
detail::SkipPointers<Encoder::skipQuantum>(list.skipPointers),
bits_(list.bits),
size_(list.size),
upperBound_(
(kUnchecked || UNLIKELY(list.size == 0)) ? 0 : list.upperBound) {
upperBound_(kUnchecked || list.size == 0 ? 0 : list.upperBound) {
reset();
}

Expand Down

0 comments on commit 50b3142

Please sign in to comment.