Skip to content

Commit

Permalink
Add per-project use-shipit flag
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookincubator/zstrong#853

For projects that can't use the simple shipit transformer (e.g. hsthrift) and projects where it would be a pain to duplicate the shipit config (e.g. Glean).

Reviewed By: pepeiborra

Differential Revision: D58055453

fbshipit-source-id: f693a320f42cfccd9808306b4ad8b1f31ce00f97
  • Loading branch information
Simon Marlow authored and facebook-github-bot committed Jun 2, 2024
1 parent e2566b5 commit 5d9c947
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions build/fbcode_builder/getdeps/manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"fbsource_path": OPTIONAL,
"shipit_project": OPTIONAL,
"shipit_fbcode_builder": OPTIONAL,
"use_shipit": OPTIONAL,
},
},
"dependencies": {"optional_section": True, "allow_values": False},
Expand Down Expand Up @@ -396,8 +397,9 @@ def get_repo_url(self, ctx):
return self.get("git", "repo_url", ctx=ctx)

def create_fetcher(self, build_options, ctx):
use_real_shipit = (
ShipitTransformerFetcher.available() and build_options.use_shipit
use_real_shipit = ShipitTransformerFetcher.available() and (
build_options.use_shipit
or self.get("manifest", "use_shipit", defval="false", ctx=ctx) == "true"
)
if (
not use_real_shipit
Expand Down

0 comments on commit 5d9c947

Please sign in to comment.