Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fbcode_builder should be synced to the mcrouter repo #2281

Open
mszabo-wikia opened this issue Aug 21, 2024 · 1 comment · May be fixed by #2282
Open

fbcode_builder should be synced to the mcrouter repo #2281

mszabo-wikia opened this issue Aug 21, 2024 · 1 comment · May be fixed by #2282

Comments

@mszabo-wikia
Copy link
Contributor

In #2268, I added fbcode_builder manifests for https://github.com/facebook/mcrouter to facilitate adding a CMake build system on top of it in facebook/mcrouter#449. Now that the PR has been merged, the changes have been propagated to several repositories that use fbcode_builder, but not mcrouter.

Could mcrouter be setup with fbcode_builder as well like those repos?

Thanks in advance!
mszabo-wikia added a commit to mszabo-wikia/folly that referenced this issue Aug 21, 2024
@mszabo-wikia
Add missing scaffolding to mcrouter manifest
c9545b9 
This seems to be necessary in order for the project to be correctly
recognized as a Meta first-party project and is likely required to
resolve facebook#2281.
@mszabo-wikia mszabo-wikia linked a pull request Aug 21, 2024 that will close this issue
Open
@mszabo-wikia
Copy link
Contributor Author

I've noticed that the manifest I added in #2268 was missing some metadata required for mcrouter to be correctly recognized as a Meta first-party project. I've just submitted a PR to add those—not sure if that'll in itself be sufficient to resolve this issue or if some other work is needed.

mszabo-wikia added a commit to mszabo-wikia/folly that referenced this issue Nov 14, 2024
@mszabo-wikia
Add missing scaffolding to mcrouter manifest
4b1db0f 
This seems to be necessary in order for the project to be correctly
recognized as a Meta first-party project and is likely required to
resolve facebook#2281.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing scaffolding to mcrouter manifest mszabo-wikia/folly
1 participant
@mszabo-wikia