Add missing scaffolding to mcrouter manifest #2282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszabo-wikia
commented
Aug 21, 2024
| @@ -21,3 +24,6 @@ BUILD_TESTS=ON | |||
|
|
|||
| [cmake.defines.test=off] | |||
| BUILD_TESTS=OFF | |||
|
|
|||
| [shipit.pathmap] | |||
| fbcode/mcrouter = mcrouter | |||
There was a problem hiding this comment.
Not sure if there are any other mappings required for this specific project.
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This seems to be necessary in order for the project to be correctly recognized as a Meta first-party project and is likely required to resolve facebook#2281.
mszabo-wikia
force-pushed
the
update-mcrouter-manifest
branch
from
2e47b65
to
4b1db0f
Compare
|
@Orvid Hi, gentle ping regarding this PR—is there anything I can do to help move things forward? Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be necessary in order for the project to be correctly recognized as a Meta first-party project and is likely required to resolve #2281.