fix windows build #2084
Closed
fix windows build #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
Summary: free up disk space to allow linux CI to pass Free up some disk from the runner and intermediate build steps as folly linux CI link step is failing with out of disk space. Regenerated CI yaml with: ./build/fbcode_builder/getdeps.py generate-github-actions --src-dir=. --free-up-disk --os-type=linux --output-dir=.github/workflows folly --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/folly/pull/2070). * #2084 * #2074 * #2068 * #2073 * __->__ #2070 Pull Request resolved: #2070 Reviewed By: genevievehelsel Differential Revision: D50568487 Pulled By: xavierd fbshipit-source-id: 271478cc5f279f220acbedc2a7d3f1252effd4b9
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 23, 2023
Summary: free up disk space to allow linux CI to pass Free up some disk from the runner and intermediate build steps as folly linux CI link step is failing with out of disk space. Regenerated CI yaml with: ./build/fbcode_builder/getdeps.py generate-github-actions --src-dir=. --free-up-disk --os-type=linux --output-dir=.github/workflows folly --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/folly/pull/2070). * facebook/folly#2084 * facebook/folly#2074 * facebook/folly#2068 * facebook/folly#2073 * __->__ facebook/folly#2070 X-link: facebook/folly#2070 Reviewed By: genevievehelsel Differential Revision: D50568487 Pulled By: xavierd fbshipit-source-id: 271478cc5f279f220acbedc2a7d3f1252effd4b9
ahornby
force-pushed
the
pr2084
branch
3 times, most recently
from
105965c
to
41126a6
Compare
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
Summary: fix linux and macOS build linux and mac build was failing: * gcc and xcode hide std::chrono::years if C++ 20 mode not set. Disable the affected test in this case * same with std::latch, also disable the affected test in this case macOS build was failing with: * missing header includes, added them macOS test run was failing with: * libcpp exception text has changed from "with" to "due to" which was breaking ExceptionTest.cpp, update the expectation to cover both. * FileUtilDetail.cpp was only enabling custom temp dir on linux, breaking FileUtilTest.cpp. Enable custom temp dir for non-windows (i.e. mac and other unix) to fix it. Pull Request resolved: #2073 Test Plan: CI. Before, build error on vector ``` CMakeFiles/tdigest_benchmark.dir/folly/stats/test/TDigestBenchmark.cpp.o -MF CMakeFiles/tdigest_benchmark.dir/folly/stats/test/TDigestBenchmark.cpp.o.d -o CMakeFiles/tdigest_benchmark.dir/folly/stats/test/TDigestBenchmark.cpp.o -c /Users/runner/work/folly/folly/folly/stats/test/TDigestBenchmark.cpp In file included from /Users/runner/work/folly/folly/folly/stats/test/TDigestBenchmark.cpp:17: /Users/runner/work/folly/folly/folly/stats/DigestBuilder.h:59:25: error: implicit instantiation of undefined template 'std::vector<double>' std::vector<double> buffer; ``` then build error on array ``` CMakeFiles/constexpr_math_test.dir/folly/test/ConstexprMathTest.cpp.o -c /Users/runner/work/folly/folly/folly/test/ConstexprMathTest.cpp /Users/runner/work/folly/folly/folly/test/ConstexprMathTest.cpp:38:29: error: implicit instantiation of undefined template 'std::array<unsigned long, 7>' std::array<res_t, size> res{}; ``` the build error on std::chrono::year ``` /Users/alex/local/folly.sapling/folly/logging/test/RateLimiterTest.cpp:124:47: error: no member named 'years' in namespace 'std::chrono' IntervalRateLimiter limiter{1, std::chrono::years{1}}; ``` then test failues After, works --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/folly/pull/2073). * #2074 * #2068 * #2084 * __->__ #2073 Reviewed By: xavierd Differential Revision: D49931137 Pulled By: Orvid fbshipit-source-id: 58830a637e73375eb648c5897dd8a1e5e479c657
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
Summary: fix linux cmake test disablement and related OOM Fix the folly linux github CI: * fix disabling the failing AtomicUnorderedInsertMap.DISABLEDMegaMap test as ctest wasn't filtering it out * fix disabling ThreadLocal.SHAREDLibraryTestName when not building shared lib The first one also fixes OOM that reliably OOM killed my terminal when running tests locally with > 2 jobs Pull Request resolved: #2146 Test Plan: Run tests locally with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages test --num-jobs 2 --src-dir=. folly ``` Before: ``` Start 1883: atomic_unordered_map_test.AtomicUnorderedInsertMap.DISABLEDMegaMap 1882/3090 Test #1883: atomic_unordered_map_test.AtomicUnorderedInsertMap.DISABLEDMegaMap ...................................***Failed 0.00 sec Note: Google Test filter = AtomicUnorderedInsertMap.DISABLEDMegaMap [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from AtomicUnorderedInsertMap [ RUN ] AtomicUnorderedInsertMap.DISABLEDMegaMap unknown file: Failure C++ exception with description "Cannot allocate memory" thrown in the test body. [ FAILED ] AtomicUnorderedInsertMap.DISABLEDMegaMap (0 ms) [----------] 1 test from AtomicUnorderedInsertMap (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (0 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] AtomicUnorderedInsertMap.DISABLEDMegaMap 1 FAILED TEST ... 1/1 Test #2774: thread_local_test.ThreadLocal.SHAREDLibraryTestName ...***Failed 0.00 sec Note: Google Test filter = ThreadLocal.SHAREDLibraryTestName [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from ThreadLocal [ RUN ] ThreadLocal.SHAREDLibraryTestName unknown file: Failure C++ exception with description "missing: folly/test/thread_local_test_lib.so" thrown in the test body. [ FAILED ] ThreadLocal.SHAREDLibraryTestName (0 ms) [----------] 1 test from ThreadLocal (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (0 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ThreadLocal.SHAREDLibraryTestName ``` After, works --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/folly/pull/2146). * #2084 * #2074 * #2068 * __->__ #2146 Reviewed By: Gownta Differential Revision: D53830611 Pulled By: Orvid fbshipit-source-id: c3eac882f2522996f897b29f5bf7d8622c1f6ceb
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This will need to be rebased before the tooling will let me import it. |
Test plan: build locally with VS 2019 Build Tools before, broken after, works
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Feb 29, 2024
Summary: fix windows build X-link: facebook/folly#2084 Reviewed By: Gownta Differential Revision: D52091412 Pulled By: Orvid fbshipit-source-id: de23d47510e06bf9652b2a92ccb0da08cc7678e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix windows build
Test plan:
build locally with VS 2019 Build Tools
before, broken
after, works