symbolizer: Fix missing unistd.h include. #2245
Conversation
Fixes `close`/`lseek`/`read`/`pread` not being in scope. It only worked so far because `#include <glog/logging.h>` apparently brought them into scope; with glog >= 0.7.0 that does not work anymore.
|
Hi @nh2! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Fixes `close`/`lseek`/`read`/`pread` not being in scope. It only worked so far because `#include <glog/logging.h>` apparently brought them into scope; with glog >= 0.7.0 that does not work anymore. See also facebook/folly#2171 (comment) X-link: facebook/folly#2245 Reviewed By: Gownta Differential Revision: D58968225 Pulled By: Orvid fbshipit-source-id: fe9b4ba3d08e910b60225d3ed6b17a314655dfe4
Fixes
close/lseek/read/preadnot being in scope.It only worked so far because
#include <glog/logging.h>apparently brought them into scope; with glog >= 0.7.0 that does not work anymore.See also #2171 (comment)