Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #2375

Closed
wants to merge 1 commit into from
Closed

fix typo #2375

wants to merge 1 commit into from
+3 −3

Conversation

chenyahui
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link
Contributor

Hi @chenyahui!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Orvid merged this pull request in 7f03c22.

facebook-github-bot pushed a commit to facebook/hhvm that referenced this pull request Jan 23, 2025
@chenyahui @facebook-github-bot
fix typo (#2375)
b5148a0 
Summary: Pull Request resolved: facebook/folly#2375

Reviewed By: yfeldblum

Differential Revision: D68509897

Pulled By: Orvid

fbshipit-source-id: f03428d602bbbb67faa2cb9d99df8923a2a203e6
Chiassonastraypatrick
Chiassonastraypatrick reviewed Jan 29, 2025
View reviewed changes
Copy link

@Chiassonastraypatrick Chiassonastraypatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look-slow{htyypeis}code-1hs(file)2sstig

folly/ThreadLocal.h
@@ -176,7 +176,7 @@ class ThreadLocalPtr {
auto rlocked = getForkGuard();
threadlocal_detail::ThreadEntry* te = StaticMeta::getThreadEntry(&id_);
auto id = id_.getOrInvalid();
// Only valid index into the the elements array
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hs1pptto.- 163:g1*<<<>>1

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hs253code1hm

@Chiassonastraypatrick Chiassonastraypatrick mentioned this pull request Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chiassonastraypatrick Chiassonastraypatrick Chiassonastraypatrick left review comments

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyahui @facebook-github-bot @Chiassonastraypatrick