Better json model load exception handling

Summary: Help debug bad characters in json files. Reviewed By: alambert Differential Revision: D70420491 fbshipit-source-id: 50ac64b32ce125ef903f62f93b42ee9d49fa52e0
facebook · Mar 4, 2025 · c13ad37 · c13ad37
1 parent fd7d527
commit c13ad37
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/hphp/hack/src/utils/hh_json/hh_json.ml b/hphp/hack/src/utils/hh_json/hh_json.ml
@@ -228,7 +228,8 @@ let js_string env =
         | 't' -> '\t'
         | 'u' ->
           let code = char_code env in
-          Char.chr code
+          (try Char.chr code with
+          | Invalid_argument _ -> syntax_error env "expected unicode")
         | x -> x
       in
       env.pos <- env.pos + 1;

diff --git a/hphp/hack/test/notebook_convert/notebook_to_hack/nb2_invalid_json.ipynb.php b/hphp/hack/test/notebook_convert/notebook_to_hack/nb2_invalid_json.ipynb.php
@@ -1,4 +1,4 @@
  Received input that was not in the expected .ipynb format
 (https://github.com/jupyter/nbformat/blob/main/nbformat/v4/nbformat.v4.schema.json)
 Error:
-"Assert_failure fbcode/hphp/hack/src/utils/hh_json/hh_json.ml:643:9""
+"Assert_failure fbcode/hphp/hack/src/utils/hh_json/hh_json.ml:644:9""