Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add ability to prevent propagating experiment ids from WWW
Summary: This diff adds the ability to prevent propagating experiment IDs from async jobs in WWW to Thrift services, and also adds gates to the methods that set & add experiment ids. I had already created the `lumos/experimentation:disable_www_exp_id_propagation` knob before I moved that logic from makeV to the specific call site in `FalcoFabricAsyncWriter`. These calls are temporary to understand whether anything is calling add/set at all. If there is logic that is somehow adding/setting experiment ids, the JK UI will display the # of hits and we'll log a warning with the ids (and get a stacktrace). If it never gets hit (ie. nothing is calling add/set experiment ids), the JK UI will show no hits, and we will know for certain that the ids are being ingested via headers. I also added a JK to control the rate at which we will log these api violations: `lumos/experimentation:www_experiment_id_api_violation_sampling_rate`. This is a safeguard in case we're somehow calling set/add experiment ids a lot, in which case we can log less by tweaking this rate. Differential Revision: D70640520 fbshipit-source-id: daf2b61fbad166b392482e37cf09f725b93d8918
- Loading branch information