-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload nightly and release deb packages to Nexus #9123
Conversation
See hhvm/packaging#311 for version schema
Differential Revision: D37704308 fbshipit-source-id: 21caaa974005511a45673c145796a104ecaf9048
The file is the encrypted GPG private key to sign deb packages, copied from https://github.com/hhvm/packaging/blob/46c7b706cb31510af57f5c3a45b5f6b0ef734126/aws/gpg-key.kms-ciphertext
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@Atry has updated the pull request. You must reimport the pull request before landing. |
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@Atry has updated the pull request. You must reimport the pull request before landing. |
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@Atry has updated the pull request. You must reimport the pull request before landing. |
@Atry has updated the pull request. You must reimport the pull request before landing. |
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This PR will upload universal deb packages to Nexus with the help of Nexus's restful API. The suite (also called distribution) to upload will be created if it does not exist, then the script will upload the deb package to the suite.
This PR is stacked on top of #9122
Known Issue:
Nexus does not support to upload a single deb package to multiple suites. Therefore, we have to upload the same package multiple times and consume unnecessary disk spaces. For example, HHVM 4.165.0 will be uploaded to both the
release
suite and therelease-4.165
suite.Fortunately, the majority of the disk space will be used by nightly builds, which should belong to the single
nightly
suite.Test Plan:
The previous commit d681f3b of this PR would unconditionally upload deb packages built from any commit to Nexus. d681f3b has been tested at https://github.com/facebook/hhvm/runs/7352684232?check_suite_focus=true . The deb packages were successfully uploaded, and can be installed with the following command
Output:
The latest commit in this PR will only upload deb packages for
nightly-*
orHHVM-*
tags. We will be able to test it only after this PR get merged.