-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing TCC permissions #796
base: main
Are you sure you want to change the base?
Conversation
@grzmiel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to add those entries to RevokeRequest as well.
idb/grpc/client.py
Outdated
@@ -187,6 +195,14 @@ | |||
Permission.LOCATION: RevokeRequest.LOCATION, | |||
Permission.NOTIFICATION: RevokeRequest.NOTIFICATION, | |||
Permission.MICROPHONE: RevokeRequest.MICROPHONE, | |||
Permission.CALENDAR: ApproveRequest.CALENDAR, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those should be RevokeRequest
@@ -255,6 +255,14 @@ message ApproveRequest { | |||
LOCATION = 4; | |||
NOTIFICATION = 5; | |||
MICROPHONE = 6; | |||
CALENDAR = 7; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the same entries in the RevokeRequest below
Do you have any new about this PR? |
These are very useful changes, what's stopping you from making a merge of changes at this point? |
Motivation
There have been several new user permissions introduced over the last couple of major iOS versions. This change adds the missing permissions that may be modified via existing TCC.db queries.
Notably, the "Health" permission is missing since it requires modification to a standalone
healthdb.sqlite
database. This will be implemented in a future PR.The following permissions have been added:
Test Plan
idb approve -h
Grant any/all of the introduced permissions for a valid bundle ID:
idb approve com.example.app calendar
Verify the supplied permissions have been successfully granted for the bundle ID
Revoke any/all of the introduced permissions for a valid bundle ID:
idb revoke com.example.app calendar
Verify the supplied permissions have been successfully revoked for the bundle ID
Related PRs