Skip to content

Commit

Permalink
Disable BasicSharedContexts tests on opengl::wgl
Browse files Browse the repository at this point in the history
Summary:
In D49297661, I added unit tests for shared contexts. The diff passed all tests when landing, but Windows unit tests are not land blocking and have been failing since when ran manually.

IGL's WGL implementation isn't complete. It's has no support for shared contexts and no logic for handling sharegroups. Instead of implementing all of that, I'm simply skipping that specific unit test, at least until someone actually needs it.

Reviewed By: EricGriffith

Differential Revision: D50542255

fbshipit-source-id: c39473ece1780932b95a24e185a6ca424a09360e
  • Loading branch information
Thiago Goulart authored and facebook-github-bot committed Oct 24, 2023
1 parent 20cb28e commit 20d51c4
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/igl/tests/ogl/Context.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include "../util/TestDevice.h"

#include <gtest/gtest.h>
#include <igl/Macros.h>
#include <igl/opengl/Device.h>
#include <igl/opengl/GLIncludes.h>
#include <igl/opengl/IContext.h>
Expand Down Expand Up @@ -313,6 +314,9 @@ TEST_F(ContextOGLTest, CheckForErrorsInvalidFrameBufferOperation) {

/// Verify that an object is visible across contexts in the same sharegroup
TEST_F(ContextOGLTest, BasicSharedContexts) {
#if IGL_PLATFORM_WIN && !IGL_ANGLE
GTEST_SKIP() << "Context sharing not implemented in opengl::wgl";
#endif
// Setup is three contexts, (1) and (2) part of the same sharegroup and (3) not.
igl::Result result;
auto sharedContext = context_->createShareContext(&result);
Expand Down

0 comments on commit 20d51c4

Please sign in to comment.