Migrate to use shared ptr to assert the command buffer surviving up t…

…o whenever the lambda scope guard gets called

Summary: ^

Reviewed By: EricGriffith

Differential Revision: D50603128

fbshipit-source-id: 4f1ab51db235f3b0b40727004007ce92ef31e0e8

samples/ios/snapshot_test_support/IGLSnapshotTestCase.mm

@@ -93,9 +93,9 @@ - (void)render {
   renderPass.colorAttachments[0].clearColor = {1.0, 1.0, 1.0, 1.0};
 
   auto cmds = commandBuffer->createRenderCommandEncoder(renderPass, _framebuffer);
-  IGL_DEBUG_BUFFER_LABEL_START(*commandBuffer, "draw renderable");
+  IGL_DEBUG_BUFFER_LABEL_START(commandBuffer, "draw renderable");
   _renderable->submit(*cmds);
-  IGL_DEBUG_BUFFER_LABEL_END(*commandBuffer);
+  IGL_DEBUG_BUFFER_LABEL_END(commandBuffer);
   cmds->endEncoding();
 
   _commandQueue->submit(*commandBuffer); // Guarantees ordering between command buffers

src/igl/CommandBuffer.h

@@ -148,12 +148,12 @@ class ICommandBuffer {
 } // namespace igl
 
 #if IGL_DEBUG && !defined(IGL_DISABLE_DEBUG_BUFFER_LABEL)
-#define IGL_DEBUG_BUFFER_LABEL_START(buffer, x) (buffer).pushDebugGroupLabel(x)
-#define IGL_DEBUG_BUFFER_LABEL_END(buffer) (buffer).popDebugGroupLabel()
+#define IGL_DEBUG_BUFFER_LABEL_START(buffer, x) (buffer)->pushDebugGroupLabel(x);
+#define IGL_DEBUG_BUFFER_LABEL_END(buffer) (buffer)->popDebugGroupLabel()
 #define IGL_DEBUG_BUFFER_LABEL_START_GUARD(buffer, x) \
   IGL_DEBUG_BUFFER_LABEL_START(buffer, x);            \
   auto popDebugGroupLabelScope =                      \
-      folly::makeGuard([&cmdBuffer = (buffer)]() { IGL_DEBUG_BUFFER_LABEL_END(cmdBuffer); });
+      folly::makeGuard([cmdBuffer = (buffer)]() { IGL_DEBUG_BUFFER_LABEL_END(cmdBuffer); });
 #else
 #define IGL_DEBUG_BUFFER_LABEL_START(buffer, x)
 #define IGL_DEBUG_BUFFER_LABEL_END(buffer)