Skip to content

Commit

Permalink
Minor: fix GLFW warnings when destroying the window
Browse files Browse the repository at this point in the history
Summary:
The code was calling glfwTerminate() before destroying the window.

I wanted to do the same for the Windows+Angle shell apps, but they aren't working for me (GL_INVALID_OPERATION on every GL call).

Differential Revision: D50761801

fbshipit-source-id: ffc23ab70d5d7ceafd35a8a44bb69ba3581befb8
  • Loading branch information
Thiago Goulart authored and facebook-github-bot committed Oct 30, 2023
1 parent 3e65954 commit 3415853
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions shell/windows/opengl/App.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,11 @@ static void RunApplicationMode(uint32_t majorVersion, uint32_t minorVersion) {
}
}

glShellPlatform_ = nullptr;
glDevice = nullptr;
context = nullptr;
glWindow = nullptr;

glfwTerminate();
}

Expand Down

0 comments on commit 3415853

Please sign in to comment.