【igl nanovg part-1】shell | ios | add stencil buffer (#214)

Summary: This is a prerequisite pull request for igl nanovg(#213). Pull Request resolved: #214 Reviewed By: EricGriffith, syeh1 Differential Revision: D66506219 Pulled By: corporateshark fbshipit-source-id: 6489cb7b9bf9d990fc50f575f1172c27c52e4ee9
facebook · Nov 27, 2024 · 49d674c · 49d674c
1 parent 5dd5465
commit 49d674c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/shell/ios/AppDelegate.mm b/shell/ios/AppDelegate.mm
@@ -42,6 +42,7 @@ - (BOOL)application:(UIApplication*)application
                              .majorVersion = 3,
                              .minorVersion = 0},
           .swapchainColorTextureFormat = igl::TextureFormat::BGRA_SRGB,
+          .depthTextureFormat = igl::TextureFormat::S8_UInt_Z32_UNorm,
       },
 #endif
 #if IGL_BACKEND_OPENGL
@@ -52,6 +53,7 @@ - (BOOL)application:(UIApplication*)application
                              .majorVersion = 3,
                              .minorVersion = 0},
           .swapchainColorTextureFormat = igl::TextureFormat::BGRA_SRGB,
+          .depthTextureFormat = igl::TextureFormat::S8_UInt_Z24_UNorm,
       },
 #endif
       {
@@ -60,6 +62,7 @@ - (BOOL)application:(UIApplication*)application
                              .majorVersion = 2,
                              .minorVersion = 0},
           .swapchainColorTextureFormat = igl::TextureFormat::BGRA_SRGB,
+          .depthTextureFormat = igl::TextureFormat::S8_UInt_Z24_UNorm,
       },
 #endif
 // @fb-only

diff --git a/shell/ios/ViewController.mm b/shell/ios/ViewController.mm
@@ -130,7 +130,7 @@ - (void)initRenderSessionController {
     IGL_DEBUG_ASSERT(platformDevice);
     return igl::SurfaceTextures{
         .color = platformDevice->createTextureFromNativeDrawable((CAEAGLLayer*)layer_, nullptr),
-        .depth = platformDevice->createTextureFromNativeDepth((CAEAGLLayer*)layer_, igl::TextureFormat::Z_UNorm16, nullptr),
+        .depth = platformDevice->createTextureFromNativeDepth((CAEAGLLayer*)layer_, config_.depthTextureFormat, nullptr),
     };
   }
 #endif

diff --git a/shell/shared/renderSession/RenderSessionConfig.h b/shell/shared/renderSession/RenderSessionConfig.h
@@ -16,6 +16,7 @@ struct RenderSessionConfig {
   std::string displayName;
   BackendVersion backendVersion;
   igl::TextureFormat swapchainColorTextureFormat = igl::TextureFormat::BGRA_UNorm8;
+  igl::TextureFormat depthTextureFormat = igl::TextureFormat::Z_UNorm16;
   igl::ColorSpace swapchainColorSpace = igl::ColorSpace::SRGB_NONLINEAR;
 };