igl | vulkan | Clean up naming

Summary: Renamed `markSubmit()` -> `markSubmitted()`. Differential Revision: D49121701 fbshipit-source-id: ad939f0a9bd71a8880a70003bb2cd81a708cd1e1
facebook · Oct 3, 2023 · 7f2864d · 7f2864d
1 parent 271f90e
commit 7f2864d
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/src/igl/vulkan/CommandQueue.cpp b/src/igl/vulkan/CommandQueue.cpp
@@ -79,8 +79,8 @@ SubmitHandle CommandQueue::endCommandBuffer(const igl::vulkan::VulkanContext& ct
   if (shouldPresent) {
     ctx.present();
   }
-  ctx.markSubmit(cmdBuffer->lastSubmitHandle_);
-  ctx.syncManager_->markSubmit(cmdBuffer->lastSubmitHandle_);
+  ctx.markSubmitted(cmdBuffer->lastSubmitHandle_);
+  ctx.syncManager_->markSubmitted(cmdBuffer->lastSubmitHandle_);
   ctx.processDeferredTasks();
 
   isInsideFrame_ = false;

diff --git a/src/igl/vulkan/SyncManager.cpp b/src/igl/vulkan/SyncManager.cpp
@@ -34,7 +34,7 @@ void SyncManager::acquireNext() noexcept {
   ctx_.immediate_->wait(submitHandles_[currentIndex_]);
 }
 
-void SyncManager::markSubmit(SubmitHandle handle) noexcept {
+void SyncManager::markSubmitted(SubmitHandle handle) noexcept {
   submitHandles_[currentIndex_] = handle;
 
   acquireNext();

diff --git a/src/igl/vulkan/SyncManager.h b/src/igl/vulkan/SyncManager.h
@@ -29,7 +29,7 @@ class SyncManager final {
 
   void acquireNext() noexcept;
 
-  void markSubmit(SubmitHandle handle) noexcept;
+  void markSubmitted(SubmitHandle handle) noexcept;
 
  private:
   const VulkanContext& ctx_;

diff --git a/src/igl/vulkan/VulkanContext.cpp b/src/igl/vulkan/VulkanContext.cpp
@@ -272,7 +272,7 @@ class DescriptorPoolsArena final {
     // @fb-only
     return dset;
   }
-  void markSubmit(VulkanImmediateCommands::SubmitHandle handle) {
+  void markSubmitted(VulkanImmediateCommands::SubmitHandle handle) {
     lastSubmitHandle_ = handle;
   }
 
@@ -1535,13 +1535,13 @@ void VulkanContext::updateBindingsStorageBuffers(VkCommandBuffer cmdBuf,
       nullptr);
 }
 
-void VulkanContext::markSubmit(const VulkanImmediateCommands::SubmitHandle& handle) const {
+void VulkanContext::markSubmitted(const VulkanImmediateCommands::SubmitHandle& handle) const {
   if (config_.enableDescriptorIndexing) {
     bindlessDSet_.handle = handle;
   }
-  arenaCombinedImageSamplers_->markSubmit(handle);
-  arenaBuffersUniform_->markSubmit(handle);
-  arenaBuffersStorage_->markSubmit(handle);
+  arenaCombinedImageSamplers_->markSubmitted(handle);
+  arenaBuffersUniform_->markSubmitted(handle);
+  arenaBuffersStorage_->markSubmitted(handle);
 }
 
 void VulkanContext::deferredTask(std::packaged_task<void()>&& task, SubmitHandle handle) const {

diff --git a/src/igl/vulkan/VulkanContext.h b/src/igl/vulkan/VulkanContext.h
@@ -326,7 +326,7 @@ class VulkanContext final {
   void updateBindingsStorageBuffers(VkCommandBuffer cmdBuf,
                                     VkPipelineBindPoint bindPoint,
                                     BindingsBuffers& data) const;
-  void markSubmit(const SubmitHandle& handle) const;
+  void markSubmitted(const SubmitHandle& handle) const;
 
   struct DeferredTask {
     DeferredTask(std::packaged_task<void()>&& task, SubmitHandle handle) :