igl | vulkan | Bounds checking

Summary: Add extra bounds checking. Reviewed By: pixelperfect3 Differential Revision: D49328718 fbshipit-source-id: c74b1ce3a1db49ab6b59e823b6668c139eaee531
facebook · Sep 16, 2023 · 9cdbcc8 · 9cdbcc8
1 parent 509c29a
commit 9cdbcc8
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/igl/vulkan/RenderCommandEncoder.cpp b/src/igl/vulkan/RenderCommandEncoder.cpp
@@ -753,7 +753,12 @@ void RenderCommandEncoder::ensureVertexBuffers() {
 
   const VertexInputStateDesc& desc = vi->desc_;
 
-  for (size_t i = 0; i != desc.numInputBindings; i++) {
+  IGL_ASSERT(desc.numInputBindings <= IGL_ARRAY_NUM_ELEMENTS(isVertexBufferBound_));
+
+  const size_t numBindings =
+      std::min(desc.numInputBindings, IGL_ARRAY_NUM_ELEMENTS(isVertexBufferBound_));
+
+  for (size_t i = 0; i != numBindings; i++) {
     if (!isVertexBufferBound_[i]) {
       // TODO: fix client apps and uncomment
       // IGL_ASSERT_MSG(false,