Skip to content

Commit

Permalink
IGL | OGL : remove unused function arg 'samples'
Browse files Browse the repository at this point in the history
Summary: After D49225157, 'samples' argument is no longer used.

Reviewed By: corporateshark

Differential Revision: D49380114

fbshipit-source-id: f440e02a03f2770ad7f0c093c2b65503fcf7a892
  • Loading branch information
Dev Mannemela authored and facebook-github-bot committed Sep 19, 2023
1 parent 364d9e7 commit b32d562
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/igl/opengl/SamplerState.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ void SamplerState::bind(ITexture* t) {
texture->setSamplerHash(hash_);

auto type = texture->getType();
auto target = texture->toGLTarget(type, texture->getSamples());
auto target = texture->toGLTarget(type);
if (target == 0) {
return;
}
Expand Down
2 changes: 1 addition & 1 deletion src/igl/opengl/Texture.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ bool Texture::isImplicitStorage() const {
return false;
}

GLenum Texture::toGLTarget(TextureType type, size_t samples) const {
GLenum Texture::toGLTarget(TextureType type) const {
switch (type) {
case TextureType::TwoD:
return GL_TEXTURE_2D;
Expand Down
2 changes: 1 addition & 1 deletion src/igl/opengl/Texture.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class Texture : public WithContext, public ITexture {

virtual bool isImplicitStorage() const;

[[nodiscard]] GLenum toGLTarget(TextureType type, size_t samples = 1) const;
[[nodiscard]] GLenum toGLTarget(TextureType type) const;
static TextureFormat glInternalFormatToTextureFormat(GLuint glTexInternalFormat,
GLuint glTexFormat,
GLuint glTexType);
Expand Down
2 changes: 1 addition & 1 deletion src/igl/opengl/TextureBuffer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ void TextureBuffer::bindImage(size_t unit) {

// create a texture for shader read/write usages
Result TextureBuffer::createTexture(const TextureDesc& desc) {
const auto target = toGLTarget(desc.type, desc.numSamples);
const auto target = toGLTarget(desc.type);
if (target == 0) {
return Result(Result::Code::Unsupported, "Unsupported texture target");
}
Expand Down

0 comments on commit b32d562

Please sign in to comment.