Skip to content

Commit

Permalink
igl | vulkan | Remove unused method VulkanExtensions::forceEnable()
Browse files Browse the repository at this point in the history
Reviewed By: EricGriffith

Differential Revision: D68132133

fbshipit-source-id: 824f81c1de74bbbb13c00e9d15550b0c26fd6e37
  • Loading branch information
corporateshark authored and facebook-github-bot committed Jan 14, 2025
1 parent 189ee35 commit cfa9d00
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
6 changes: 0 additions & 6 deletions src/igl/vulkan/VulkanExtensions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,6 @@ bool VulkanExtensions::enable(const char* extensionName, ExtensionType extension
return false;
}

void VulkanExtensions::forceEnable(const char* extensionName, ExtensionType extensionType) {
const size_t vectorIndex = (size_t)extensionType;

enabledExtensions_[vectorIndex].insert(extensionName);
}

void VulkanExtensions::enableCommonInstanceExtensions(const VulkanContextConfig& config) {
enable(VK_KHR_SURFACE_EXTENSION_NAME, ExtensionType::Instance);
enable(VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME, ExtensionType::Instance);
Expand Down
8 changes: 1 addition & 7 deletions src/igl/vulkan/VulkanExtensions.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace igl::vulkan {
/// type, checking whether an extension is available without modifying the internal storage of the
/// object, checking if an extension has been enabled for an object and, finally, a method to return
/// a list of all enabled extensions of a type as `const char *`, which is accepted by the
/// VUlkan API
/// Vulkan API
class VulkanExtensions final {
public:
/// @brief Helper enumeration to determine which extension is being used. It's converted to a
Expand Down Expand Up @@ -82,12 +82,6 @@ class VulkanExtensions final {
/// @return True if the extension has been enabled, false otherwise
bool enabled(const char* extensionName) const;

/// @brief Enables the extension with name `extensionName` of the type `extensionType`.
/// Use this method to enable prorietory extensions which are not reported in the extensions list.
/// @param extensionName The name of the extension
/// @param extensionType The type of the extension
void forceEnable(const char* extensionName, ExtensionType extensionType);

/// @brief Returns a vector of `const char *` of all enabled extensions for an instance or phyical
/// device. This method is particularly useful because Vulkan expects an
/// array of `const char *` with the names of the extensions to enable
Expand Down

0 comments on commit cfa9d00

Please sign in to comment.