igl | vulkan | Don't create temporary smartpointers

Summary: Don't create temporary smartpointers. Differential Revision: D49976472 fbshipit-source-id: c797b8592060df0b333a120b84644d0a33612d22
facebook · Oct 7, 2023 · e3437b8 · e3437b8
1 parent 1ced71b
commit e3437b8
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/igl/vulkan/CommandBuffer.cpp b/src/igl/vulkan/CommandBuffer.cpp
@@ -48,13 +48,11 @@ std::unique_ptr<IRenderCommandEncoder> CommandBuffer::createRenderCommandEncoder
   // prepare all the color attachments
   const auto& indices = framebuffer->getColorAttachmentIndices();
   for (auto i : indices) {
-    const auto colorTex = framebuffer->getColorAttachment(i);
-    transitionToColorAttachment(wrapper_.cmdBuf_, colorTex.get());
+    ITexture* colorTex = framebuffer->getColorAttachment(i).get();
+    transitionToColorAttachment(wrapper_.cmdBuf_, colorTex);
     // handle MSAA
-    const auto colorResolveTex = framebuffer->getResolveColorAttachment(i);
-    if (colorResolveTex) {
-      transitionToColorAttachment(wrapper_.cmdBuf_, colorResolveTex.get());
-    }
+    ITexture* colorResolveTex = framebuffer->getResolveColorAttachment(i).get();
+    transitionToColorAttachment(wrapper_.cmdBuf_, colorResolveTex);
   }
 
   // prepare depth attachment