mvfstEnableFlowControlTimeBasedUpdates -> mvfstDisableFlowControlTime…

…BasedUpdates Summary: That way we can keep the default to false in the mc. This makes adding params to ios or other platforms easier Reviewed By: NishantNori Differential Revision: D64791939 fbshipit-source-id: 23cf0e7962619d4754a766537a5cb87e92a22487
facebook · Oct 23, 2024 · 0cbf963 · 0cbf963
1 parent 0912ed3
commit 0cbf963
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/quic/flowcontrol/QuicFlowController.cpp b/quic/flowcontrol/QuicFlowController.cpp
@@ -34,7 +34,7 @@ Optional<uint64_t> calculateNewWindowUpdate(
       (updateTime - *lastSendTime) >
           transportSettings.flowControlRttFrequency * srtt;
   // If we are autotuning then frequent updates aren't required.
-  if (transportSettings.enableFlowControlTimeBasedUpdates &&
+  if (!transportSettings.disableFlowControlTimeBasedUpdates &&
       enoughTimeElapsed && !transportSettings.autotuneReceiveConnFlowControl) {
     return nextAdvertisedOffset;
   }

diff --git a/quic/state/TransportSettings.h b/quic/state/TransportSettings.h
@@ -398,7 +398,7 @@ struct TransportSettings {
   double ackTimerFactor{kAckTimerFactor};
   // If flow control updates should be sent based on time passed since last
   // update.
-  bool enableFlowControlTimeBasedUpdates{true};
+  bool disableFlowControlTimeBasedUpdates{false};
   // Check if idle timer needs to be triggered manually.
   bool checkIdleTimerOnWrite{false};
   // Whether to process callbacks per received packet.