Skip to content

Commit

Permalink
Set bandwidthHi when entering Drain
Browse files Browse the repository at this point in the history
Summary:
When BBR2 switches from Startup to Drain, it starts applying a limit on pacing using bandwidthHi_. If this transition happens around an idleRestart, populating bandwidthHi_ from bandwidthLatest only, can result in lower samples that underutilize the link.

This change ensures that transitioning from Startup to Drain maintains the pacing rate.

Reviewed By: mjoras

Differential Revision: D49550971

fbshipit-source-id: 8f2644e8636382bc3498b3ec9c82e98cd15aa6d2
  • Loading branch information
jbeshay authored and facebook-github-bot committed Sep 26, 2023
1 parent 10161ff commit 25bde28
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions quic/congestion_control/Bbr2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ void Bbr2CongestionController::checkStartupDone() {
checkStartupHighLoss();

if (state_ == State::Startup && filledPipe_) {
bandwidthHi_ = maxBwFilter_.GetBest();
enterDrain();
}
}
Expand Down

0 comments on commit 25bde28

Please sign in to comment.