Skip to content

Commit

Permalink
Move core functionality to QuicTransportBaseLite [23/n]
Browse files Browse the repository at this point in the history
Summary: See title.

Reviewed By: hanidamlaj

Differential Revision: D65605100

fbshipit-source-id: aaa7f394b6699401ff84c1e5ed010e42670e39f0
  • Loading branch information
Aman Sharma authored and facebook-github-bot committed Nov 9, 2024
1 parent d4cc0c2 commit 3f7555a
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 22 deletions.
64 changes: 44 additions & 20 deletions quic/api/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -45,56 +45,42 @@ mvfst_cpp_library(
mvfst_cpp_library(
name = "transport",
srcs = [
"IoBufQuicBatch.cpp",
"QuicPacketScheduler.cpp",
"QuicTransportBase.cpp",
"QuicTransportBaseLite.cpp",
"QuicTransportFunctions.cpp",
],
headers = [
"IoBufQuicBatch.h",
"QuicPacketScheduler.h",
"QuicSocket.h",
"QuicSocketLite.h",
"QuicTransportBase.h",
"QuicTransportBaseLite.h",
"QuicTransportFunctions.h",
],
deps = [
":loop_detector_callback",
":quic_batch_writer",
"//folly:chrono",
"//folly:scope_guard",
"//folly/tracing:static_tracepoint",
"//quic/common:buf_accessor",
"//quic/common:socket_util",
"//quic/common:time_util",
"//quic/congestion_control:ecn_l4s_tracker",
"//quic/congestion_control:pacer",
"//quic/happyeyeballs:happyeyeballs",
"//quic/flowcontrol:flow_control",
"//quic/logging:qlogger_constants",
"//quic/loss:loss",
"//quic/state:ack_frequency_functions",
"//quic/state:ack_handler",
"//quic/state:pacing_functions",
"//quic/state:simple_frame_functions",
"//quic/state:state_functions",
"//quic/state:stream_functions",
"//quic/state/stream:stream",
],
exported_deps = [
":quic_batch_writer",
":quic_callbacks",
":transport_helpers",
"//folly:exception_wrapper",
"//folly:expected",
"//folly:maybe_managed_ptr",
"//folly:portability",
"//folly/io:iobuf",
"//folly/io/async:async_transport_certificate",
"//folly/lang:assume",
"//quic:constants",
"//quic:exception",
"//quic/client:state_and_handshake",
"//quic/codec:codec",
"//quic/codec:pktbuilder",
"//quic/codec:pktrebuilder",
"//quic/codec:types",
"//quic/common:looper",
"//quic/common:network_data",
Expand All @@ -108,7 +94,6 @@ mvfst_cpp_library(
"//quic/congestion_control:copa",
"//quic/congestion_control:cubic",
"//quic/congestion_control:newreno",
"//quic/flowcontrol:flow_control",
"//quic/handshake:transport_parameters",
"//quic/observer:socket_observer_container",
"//quic/observer:socket_observer_types",
Expand All @@ -117,6 +102,45 @@ mvfst_cpp_library(
"//quic/state:quic_state_machine",
"//quic/state:quic_stream_utilities",
"//quic/state:retransmission_policy",
],
)

mvfst_cpp_library(
name = "transport_helpers",
srcs = [
"IoBufQuicBatch.cpp",
"QuicPacketScheduler.cpp",
"QuicTransportFunctions.cpp",
],
headers = [
"IoBufQuicBatch.h",
"QuicPacketScheduler.h",
"QuicTransportFunctions.h",
],
deps = [
"//folly/tracing:static_tracepoint",
"//quic/common:buf_accessor",
"//quic/common:socket_util",
"//quic/happyeyeballs:happyeyeballs",
"//quic/state:ack_frequency_functions",
"//quic/state:ack_handler",
"//quic/state:simple_frame_functions",
],
exported_deps = [
":quic_batch_writer",
"//folly:expected",
"//folly/lang:assume",
"//quic:constants",
"//quic:exception",
"//quic/client:state_and_handshake",
"//quic/codec:codec",
"//quic/codec:pktbuilder",
"//quic/codec:pktrebuilder",
"//quic/codec:types",
"//quic/common/udpsocket:quic_async_udp_socket",
"//quic/flowcontrol:flow_control",
"//quic/handshake:transport_parameters",
"//quic/state:quic_state_machine",
"//quic/state:state_functions",
"//quic/state:stats_callback",
"//quic/state:stream_functions",
Expand Down
2 changes: 1 addition & 1 deletion quic/api/QuicTransportBaseLite.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ bool QuicTransportBaseLite::isBidirectionalStream(StreamId stream) noexcept {
return quic::isBidirectionalStream(stream);
}

QuicSocket::WriteResult QuicTransportBaseLite::writeChain(
QuicSocketLite::WriteResult QuicTransportBaseLite::writeChain(
StreamId id,
Buf data,
bool eof,
Expand Down
1 change: 0 additions & 1 deletion quic/api/QuicTransportFunctions.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include <quic/QuicException.h>
#include <quic/api/IoBufQuicBatch.h>
#include <quic/api/QuicPacketScheduler.h>
#include <quic/api/QuicSocket.h>
#include <quic/common/udpsocket/QuicAsyncUDPSocket.h>
#include <quic/handshake/TransportParameters.h>
#include <quic/state/StateData.h>
Expand Down

0 comments on commit 3f7555a

Please sign in to comment.