[RN][CI] Test Old Arch with Maestro

facebook · Dec 2, 2024 · e124dec · e124dec
1 parent abfa3a2
commit e124dec
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml
@@ -221,7 +221,7 @@ jobs:
           flavor: ${{ matrix.flavor }}
 
   test_e2e_ios_templateapp:
-    if: ${{ github.ref == 'refs/heads/main' || contains(github.ref,  'stable') || inputs.run-e2e-tests }}
+    #if: ${{ github.ref == 'refs/heads/main' || contains(github.ref,  'stable') || inputs.run-e2e-tests }}
     runs-on: macos-13-large
     needs: build_npm_package
     env:
@@ -233,6 +233,7 @@ jobs:
       matrix:
         jsengine: [Hermes, JSC]
         flavor: [Debug, Release]
+        architecture: [OldArch, NewArch]
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -277,7 +278,12 @@ jobs:
 
           cd /tmp/RNTestProject/ios
           bundle install
-          HERMES_ENGINE_TARBALL_PATH=$HERMES_PATH bundle exec pod install
+          NEW_ARCH_ENABLED=1
+          if [[ ${{ matrix.architecture }} == "OldArch" ]]; then
+            echo "Disable the New Architecture"
+            NEW_ARCH_ENABLED=0
+          fi
+          HERMES_ENGINE_TARBALL_PATH=$HERMES_PATH RCT_NEW_ARCH_ENABLED=$NEW_ARCH_ENABLED bundle exec pod install
 
           xcodebuild \
             -scheme "RNTestProject" \
@@ -297,7 +303,7 @@ jobs:
           working-directory: /tmp/RNTestProject
 
   test_e2e_android_templateapp:
-    if: ${{ github.ref == 'refs/heads/main' || contains(github.ref,  'stable') || inputs.run-e2e-tests }}
+    #if: ${{ github.ref == 'refs/heads/main' || contains(github.ref,  'stable') || inputs.run-e2e-tests }}
     runs-on: 4-core-ubuntu
     needs: build_npm_package
     continue-on-error: true
@@ -306,6 +312,7 @@ jobs:
       matrix:
         jsengine: [Hermes, JSC]
         flavor: [debug, release]
+        architecture: [OldArch, NewArch]
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -351,6 +358,11 @@ jobs:
           cd /tmp/RNTestProject
           echo "react.internal.mavenLocalRepo=$MAVEN_LOCAL" >> android/gradle.properties
 
+          if [[ ${{matrix.architecture}} == "OldArch" ]]; then
+            echo "Disabling the New Architecture"
+            sed -i 's/newArchEnabled=true/newArchEnabled=false/' android/gradle.properties
+          fi
+
           # Build
           cd android
           CAPITALIZED_FLAVOR=$(echo "${{ matrix.flavor }}" | awk '{print toupper(substr($0, 1, 1)) substr($0, 2)}')