Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow async functions in ReactNativeTester and add tests #48063

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow async functions in ReactNativeTester and add tests #48063

wants to merge 1 commit into from
+73 −1

Conversation

rubennorte
Copy link
Contributor

Summary:
Changelog: [internal]

This allows async functions to be passed to runTask (just a type change really) and adds tests for ReactNativeTester. Error handling isn't currently set up correctly, so those tests are disabled for now.

Differential Revision: D66698547

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 3, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66698547

@rubennorte @facebook-github-bot
Allow async functions in ReactNativeTester and add tests (facebook#48063
d9cba8e 
)

Summary:

Changelog: [internal]

This allows async functions to be passed to `runTask` (just a type change really) and adds tests for ReactNativeTester. Error handling isn't currently set up correctly, so those tests are disabled for now.

Reviewed By: sammy-SC

Differential Revision: D66698547
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66698547

rubennorte added a commit to rubennorte/react-native that referenced this pull request Dec 4, 2024
@rubennorte @facebook-github-bot
Allow async functions in ReactNativeTester and add tests (facebook#48063
5475e6f 
)

Summary:

Changelog: [internal]

This allows async functions to be passed to `runTask` (just a type change really) and adds tests for ReactNativeTester. Error handling isn't currently set up correctly, so those tests are disabled for now.

Reviewed By: sammy-SC

Differential Revision: D66698547
rubennorte added a commit to rubennorte/react-native that referenced this pull request Dec 4, 2024
@rubennorte @facebook-github-bot
Allow async functions in ReactNativeTester and add tests (facebook#48063
592d8b4 
)

Summary:

Changelog: [internal]

This allows async functions to be passed to `runTask` (just a type change really) and adds tests for ReactNativeTester. Error handling isn't currently set up correctly, so those tests are disabled for now.

Reviewed By: sammy-SC

Differential Revision: D66698547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubennorte @facebook-github-bot