Re-introduce the deprecated constructor on ReactModuleInfo #48090
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66755541 |
…48090) Summary: This alleviates a breaking change on `ReactModuleInfo` constructor. While the ctor was deprecated, we realized that there are more than 250 usages in OSS. We'll need to properly communicate this removal before we do it. Changelog: [Android] [Fixed] - Re-introduce the deprecated constructor on ReactModuleInfo Reviewed By: cipolleschi Differential Revision: D66755541
cortinico
force-pushed
the
export-D66755541
branch
from
175fdb1
to
91cef63
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66755541 |
|
This pull request was successfully merged by @cortinico in 734730d When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This alleviates a breaking change on
ReactModuleInfoconstructor.While the ctor was deprecated, we realized that there are more than 250 usages in OSS.
We'll need to properly communicate this removal before we do it.
Changelog:
[Android] [Fixed] - Re-introduce the deprecated constructor on ReactModuleInfo
Differential Revision: D66755541