report an event tracking the event loop perf in metro dev middleware #49674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69988265 |
vzaidman
force-pushed
the
export-D69988265
branch
from
e482fdb to
3732b7e
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Feb 27, 2025
…acebook#49674) Summary: Changelog: [General][Internal] - report an event tracking the event loop perf in metro dev middleware Differential Revision: D69988265
|
This pull request was exported from Phabricator. Differential Revision: D69988265 |
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Feb 27, 2025
…acebook#49674) Summary: Pull Request resolved: facebook#49674 Changelog: [General][Internal] - report an event tracking the event loop perf in metro dev middleware Differential Revision: D69988265
vzaidman
force-pushed
the
export-D69988265
branch
from
3732b7e to
ba06c3e
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Feb 28, 2025
…acebook#49674) Summary: Changelog: [General][Internal] - report an event tracking the event loop perf in metro dev middleware Reviewed By: hoxyq Differential Revision: D69988265
vzaidman
force-pushed
the
export-D69988265
branch
from
ba06c3e to
f8d0f32
Compare
Differential Revision: D70324724
Summary: The terminal status display is not very good with handling interactive status updates: 1. It swallows logs in between, in the very critical moment where we log the initial state of Metro statup. 2. Some logs appear next to updates 3. We end up with ghost update lines, ending up spamming the console with previous status updates. I tried fixing it, and realized it's at least hard (if not impossible if there are several terminal sources like node warnings, console.log, etc...). I think it is not worth maintaining. Instead- I came up with a new heuristic to print only 4 updates for each bundle: * 0%, 33%, 66%, 99%, and then on success. * Also, don't print anything for less than 50 total files being transformed. For smaller bundles we will jump from 0 to success quickly enough. For bigger bundles, by the time we reach 50, we seem to have a more reliable progress indication available despite `totalCount` progressively growing. Changelog: [General][Internal] remove interactive bundling status bars Differential Revision: D70381801
Differential Revision: D70402368
Differential Revision: D70403987
Differential Revision: D70403999
Differential Revision: D69988266
vzaidman
force-pushed
the
export-D69988265
branch
from
f8d0f32 to
f861a57
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Feb 28, 2025
…acebook#49674) Summary: Changelog: [General][Internal] - report an event tracking the event loop perf in metro dev middleware Reviewed By: hoxyq Differential Revision: D69988265
vzaidman
force-pushed
the
export-D69988265
branch
from
f861a57 to
0fe9e5f
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Feb 28, 2025
…acebook#49674) Summary: Changelog: [General][Internal] - report an event tracking the event loop perf in metro dev middleware Reviewed By: hoxyq Differential Revision: D69988265
|
This pull request was exported from Phabricator. Differential Revision: D69988265 |
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Feb 28, 2025
…acebook#49674) Summary: Pull Request resolved: facebook#49674 Changelog: [General][Internal] - report an event tracking the event loop perf in metro dev middleware Reviewed By: hoxyq Differential Revision: D69988265
vzaidman
force-pushed
the
export-D69988265
branch
from
0fe9e5f to
b64a1fd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69988265 |
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Feb 28, 2025
…acebook#49674) Summary: Pull Request resolved: facebook#49674 Changelog: [General][Internal] - report an event tracking the event loop perf in metro dev middleware Reviewed By: hoxyq Differential Revision: D69988265
vzaidman
force-pushed
the
export-D69988265
branch
from
b64a1fd to
d83a606
Compare
…acebook#49674) Summary: Pull Request resolved: facebook#49674 Changelog: [General][Internal] - report an event tracking the event loop perf in metro dev middleware Reviewed By: hoxyq Differential Revision: D69988265
|
This pull request was exported from Phabricator. Differential Revision: D69988265 |
vzaidman
force-pushed
the
export-D69988265
branch
from
d83a606 to
6ddd0a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General][Internal] - report an event tracking the event loop perf in metro dev middleware
Differential Revision: D69988265