feat[Tree]: set initial scroll offset when inspected element index is…

… set
facebook · Jan 7, 2025 · ecb8df4 · ecb8df4
1 parent 6356de4
commit ecb8df4
Showing 1 changed file with 20 additions and 2 deletions.
diff --git a/packages/react-devtools-shared/src/devtools/views/Components/Tree.js b/packages/react-devtools-shared/src/devtools/views/Components/Tree.js
@@ -49,9 +49,23 @@ export type ItemData = {
   treeFocused: boolean,
 };
 
-type Props = {};
+function calculateInitialScrollOffset(
+  inspectedElementIndex: number | null,
+  elementHeight: number,
+): number | void {
+  if (inspectedElementIndex === null) {
+    return undefined;
+  }
+
+  if (inspectedElementIndex < 3) {
+    return undefined;
+  }
+
+  // Make 3 elements on top of the inspected one visible
+  return (inspectedElementIndex - 3) * elementHeight;
+}
 
-export default function Tree(props: Props): React.Node {
+export default function Tree(): React.Node {
   const dispatch = useContext(TreeDispatcherContext);
   const {
     numElements,
@@ -426,6 +440,10 @@ export default function Tree(props: Props): React.Node {
                 <FixedSizeList
                   className={styles.List}
                   height={height}
+                  initialScrollOffset={calculateInitialScrollOffset(
+                    inspectedElementIndex,
+                    lineHeight,
+                  )}
                   innerElementType={InnerElementType}
                   itemCount={numElements}
                   itemData={itemData}