[ESLint] exhaustive-deps rule to also check useInsertionEffect
#31969
+307
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
eslint-plugin-react-hookspackage so that theexhaustive-depsrule would also checkuseInsertionEffect.'useInsertionEffect'as an additional hook in the ESLint config file, but considering that this is a built-in hook, it would make more sense foreslint-plugin-react-hooksto handle this out of the box.How did you test this change?
ESLintRuleExhaustiveDeps-test.jshave been updated to also test this change.useLayoutEffect.Please let me know if any scenario is not covered or if my changes to the test are inappropriate as I might have misunderstood the purpose of the existing tests that I was referencing to.