Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more function prototypes to avoid implicit function declarations #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fweimer-rh
Copy link

These functions are used in other parts of the codebase. Future compilers may reject implicit function declarations by default; they were removed from C in 1999.

Related to:

These functions are used in other parts of the codebase.  Future
compilers may reject implicit function declarations by default;
they were removed from C in 1999.
@facebook-github-bot
Copy link

Hi @fweimer-rh!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@elizabethjoshi
Copy link

need a Contributor License Agreement to proceed.
Check: https://github.com/facebook/tac_plus/pull/36/checks?check_run_id=10203698271

@RollerMatic
Copy link
Contributor

hey @fweimer-rh , do you mind accepting the CLA ? We can merge this with master, but need the stamp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants