Checked translation

[izabellamatos]

I checked if lang_en.php had all of application texts and added what was missing. I also noticed that some texts weren't being translated by "tr" function.
IMPORTANT 1: I could not translate texts inside fbct/src/static/js .
IMPORTANT 2: All translations need to be revised in order to add what was missing.

[justinwray]

There are definitely some missing translations (even from English) based on new changes that didn't incorporate the corresponding translations.

Quick note:

{tr($action_text)}

We generally try to stay away from translating dynamic items (and instead translate the source). We will go through the rest of the translations and review. Thank you for the contribution!

[izabellamatos]

justinwray,

Oh sorry!! I couldn't find any other way to translate that. I tried to copy from countries management:

Countries Management

if ($country->getEnabled()) {
        $highlighted_action = 'disable_country';
        $highlighted_color = 'highlighted--red country-enabled';
        $current_status = 'Disabled';
      } else {
        $highlighted_action = 'enable_country';
        $highlighted_color = 'highlighted--green country-disabled';
        $current_status = 'Enabled';
      }

      if (!$using_country) {
        $status_action =
          <a
            class={$highlighted_color}
            href="#"
            data-action={str_replace('_', '-', $highlighted_action)}>
--->>    {tr($current_status)}
          </a>;
      } else {
        $status_action = <a class={$highlighted_color}></a>;
      }

Logo Management

if ($logo->getEnabled()) {
        $highlighted_action = 'disable_logo';
        $highlighted_color = 'highlighted--red';
      } else {
        $highlighted_action = 'enable_logo';
        $highlighted_color = 'highlighted--green';
      }
      $action_text = strtoupper(explode('_', $highlighted_action)[0]);

      if ($using_logo) {
        $use_select = <select class="not_configuration"></select>;
        foreach ($using_logo as $t) {
          $use_select->appendChild(<option value="">{$t->getName()}</option>);
        }
      } else {
        $use_select =
          <select class="not_configuration">
            <option value="0">{tr('None')}</option>
          </select>;
      }

      $adminsections->appendChild(
        <section class="admin-box">
          <form class="logo_form">
            <input
              type="hidden"
              name="logo_id"
              value={strval($logo->getId())}
            />
            <input
              type="hidden"
              name="status_action"
              value={strtolower($action_text)}
            />
            <header class="management-header">
              <h6>ID{strval($logo->getId())}</h6>
              <a
                class={$highlighted_color}
                href="#"
                data-action={str_replace('_', '-', $highlighted_action)}>
--->>        {tr($action_text)}
              </a>

I guess we should correct both, right? Like:
$current_status = {tr('Disabled')}; --> countries management

if ($logo->getEnabled()) {
$highlighted_action = 'disable_logo';
$highlighted_color = 'highlighted--red';
$action_text = {tr('Disable')}; --> logo management

  } else {
    $highlighted_action = 'enable_logo';
    $highlighted_color = 'highlighted--green';
    $action_text = {tr('Enable')}; --> logo management
  }

[fredemmott]

You have an unresolved merge conflict here