Remove the cmake configuration machinery for config.hpp #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
denizevrenci
force-pushed
the
config_hpp
branch
2 times, most recently
from
b87b5c5 to
1395044
Compare
|
Looks like this addresses #510. |
ispeters
requested changes
Apr 16, 2024
denizevrenci
force-pushed
the
config_hpp
branch
from
1395044 to
7ed0034
Compare
We can rely on the preprocessor for it instead since we only support C++17 and above.
denizevrenci
force-pushed
the
config_hpp
branch
from
7ed0034 to
9538725
Compare
ispeters
approved these changes
Apr 16, 2024
ispeters
pushed a commit
to ispeters/compiler-explorer-infra
that referenced
this pull request
Aug 16, 2024
As of Unifex's PR 606[1] this past April, Unifex's `config.hpp` is self-contained and does build-time configuration with the preprocessor so we don't need a custom configuration step anymore. This PR deletes the Compiler Explorer's copy of the customized `config.hpp` and the build step that overwrites the upstream header with that custom copy. I expect this change to resolve #6711 but I don't know how to test that claim. 1. facebookexperimental/libunifex#606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can rely on the preprocessor for it instead since we only support C++17 and above.
Closes #510