Fix cancellation bug in async_auto_reset_event #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
We found that `async_auto_reset_event` doesn't compose with `stop_when` because of a bug in `async_auto_reset_event`. This diff adds a regression test that used to fail and the fix.
ispeters
force-pushed
the
fix_async_auto_reset_event_cancellation
branch
from
41fcdc7 to
f931be4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that
async_auto_reset_eventdoesn't compose withstop_whenbecause of a bug inasync_auto_reset_event. This diff adds a regression test that used to fail and the fix.