Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pixel not appending properly with Gravity Forms redirect confirmations #3

Closed
wants to merge 3 commits into from
Closed

Conversation

travislopes
Copy link
Contributor

Description

This PR fixes an issue where Gravity Forms confirmations do not process properly when the Facebook Pixel is added to a redirect type confirmation.

When a redirect type confirmation is used, the confirmation is updated to return the Facebook Pixel along with a Javascript based redirect rather than using Gravity Forms' header based redirect.

(Related Issue: #2)

Testing Instructions

  1. Create a Gravity Forms form.
  2. Set the default confirmation to the Text type.
  3. Submit the form.
  4. Confirm the Facebook Pixel is properly included and event was registered.
  5. Change the default confirmation to the Page type.
  6. Submit the form.
  7. Confirm the Facebook Pixel is properly included, the event was registered and user was redirected to selected page.
  8. Change the default confirmation to the Redirect type.
  9. Submit the form.
  10. Confirm the Facebook Pixel is properly included, the event was registered and user was redirected to the defined redirect URL.

@travislopes travislopes marked this pull request as ready for review September 19, 2019 16:16
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinothsa is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@vinothsa merged this pull request in 628ebf2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants